Remove references to iptables#477
Merged
Merged
Conversation
This is a follow-up of containers/netavark#1353 containers/podman#27555 And related to https://issues.redhat.com/browse/RUN-3723 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
mtrmac
approved these changes
Nov 22, 2025
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
This LGTM, and merging as is, because this is clearly necessary to follow the removal from Netavark.
… but there are other references to iptables in the repo (PATH updates, SELinux labeling, and more). Do those need to be updated as well?
Member
PATH likely has to stay as we still execute nftables, selinux and the likely needs to be checked. There is a bunch of extra logic for the rootless netns because iptables had to write to /run/xtables.lock IIRC so there is room to futher simplify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of
containers/netavark#1353
containers/podman#27555
And related to https://issues.redhat.com/browse/RUN-3723