Add golang client #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
force-pushed
the
go-client
branch
4 times, most recently
from
6666732 to
1b029a1
Compare
rphillips
reviewed
Nov 16, 2021
This adds an example golang client by doing the same like the rust client. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
go-client
branch
from
1b029a1 to
970522b
Compare
|
hold this for now, I think we may want to make a fully fledged library instead of a client example |
|
Converted back to draft, @haircommander feel free to close if you wanna move over the code into your WIP. |
|
BTW I'm interested in your experience with cap'n proto for IPC between Rust and Go, since I have the same use case for https://github.com/containers/containers-image-proxy-rs and skopeo. At a quick glance, it looks like capnproto/capnproto-rust#204 (comment) is the status quo on fd passing, which I think I would want versus passing all the bytes over the socketpair. |
Yeah I was thinking if IPC would be usable for us as well. |
|
Part of #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an example golang client by doing the same like the rust
client.