Don’t retry on errcode.ErrorCodeDenied #727
Conversation
|
LGTM |
|
@mtrmac What do you want to do with this PR? |
|
This becomes necessary for containers/image#1299 , which I still need to finish — so this c/common PR is somewhat of a reminder to myself that it will need to happen (and be tested). If someone wants to test this artificially, or merge without testing, considering it low-risk, that’s fine with me. Alternatively, I could add a set of unit tests to the logic right now. That’s not the same as practical testing, but it would add longer-term confidence. |
|
I would be fine with merging this as is. |
rhatdan
changed the title
|
@mtrmac Can you take it out of Draft mode. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Document that it should be tested after the various concrete types - Explicitly return false on nil, which can be returned by .Unwrap() Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will add one more item, so fold this line in advance. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
In most cases, the registry returns a multi-error (ErrorCodeDenied, ErrorCodeUnauthorized), but we want to modify the registry client to only return the first one. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/lgtm |
3 participants
See containers/image#1299 for full rationale. Completely untested for now.