pgk/capabilities: modernize, switch to github.com/moby/sys/capability #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
cross build for darwin is failing |
Kernel 2.6.32-573.el6, released 2015-07-22 as part of RHEL 6.7, supports cap_last_cap file, so there is no need for a workaround. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
sync.OnceValues is available since Go 1.21 and allows to have less global variables when using sync.Once. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
slices.Sort was introduced in Go 1.21. As the code already imports slices, using slices.Sort allows to have one less package imported. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Replace init and the two global variables with two functions, capList and capStrList, wrapped in sync.OnceValues. This way, there is no runtime overhead of merely including this package, as these functions are executed as needed, not during program initialization. While at it: - rename getCapName to capName for brewity; - use slices.DeleteFunc in capList to filter the slice in place instead of making a copy (less garbage to collect); - improve AllCapabilities documentation. Note that currently neither function returns an error; this is a preparation for the next patch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is a fork of the (no longer maintained) github.com/syndtr/gocapability package. For changes since the fork took place, see https://github.com/moby/sys/blob/main/capability/CHANGELOG.md Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Luap99
approved these changes
Sep 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves pkg/capabilities and switches it to using the new fork. Please see individual commits for details.
github.com/moby/sys/capability is a fork of the (no longer maintained) github.com/syndtr/gocapability package.
For changes since the fork took place, see https://github.com/moby/sys/blob/main/capability/CHANGELOG.md
Related: