Vendor in latest containers/(storage, image)

[rhatdan]

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

[rhatdan]

@edsantiago PTAL

[rhatdan]

@mtrmac @vrothberg @flouthoc @mheon PTAL

[mheon]

Fixing the GetLockfile -> GetLockFile bit in Podman is going to be fun.

LGTM

[vrothberg]

/hold

We need an accompanying PR against Podman. Otherwise, we cannot vendor-in c/common until that is fixed which will potentially block other work.

[flouthoc]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@vrothberg I am working this through the entire process to get there. I plan on working this through into Buildah and then into Podman. I also have PR for containers/image opened.

[rhatdan]

BTW Nothing is breaking except for linters complaining about depracated interfaces.

[rhatdan]

PR Opened containers/podman#16744

[mtrmac]

Fixing the GetLockfile -> GetLockFile bit in Podman is going to be fun.

That exists in containers/podman#16581 ; if that is merged, then c/common can be vendored, or not, into Podman at any unrelated time.

(It’s also still an option to remove the deprecation annotation from c/storage’s lockfile.Locker; it’s an interface we can’t evolve, but existing users who are happy with the previous set of capabilities can continue to use it just fine, and only migrate to a the new non-interface if they need the newly added methods. I think it’s cleaner to deprecate it — primarily to inform future work in c/storage — but that’s a very weak opinion and the downsides in downstream consumers are apparent.)

[rhatdan]

Since storage was merged into Podman, I am merging this.