conformance tests: more parallelization#6851
Open
nalind wants to merge 1 commit into
Open
Conversation
nalind
force-pushed
the
moar-parallelism
branch
5 times, most recently
from
24cc927 to
1879631
Compare
Member
Author
|
Looks like that conformance-using-vfs job really is I/O bound. |
nalind
force-pushed
the
moar-parallelism
branch
3 times, most recently
from
93fe884 to
b5404bb
Compare
Parallelize more subtests. Use t.Cleanup() instead of "defer" for a few cleanups. CI: give conformance tasks a bit more time, since the slower one appears to be limited by I/O more than CPU threads or memory. Give it more CPU threads and memory anyway. CI: don't run "make all" before making the test target; we fixed the target dependencies in the Makefile so that targets ensure that what they need has been built before use. CI: build the buildah binary for the buildah_version and buildah_info tasks. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Parallelize more subtests to try to finish conformance testing faster.
Use t.Cleanup() instead of defer for a few cleanups.
How to verify it
Conformance tests should complete in less time unless they're I/O bound.
Which issue(s) this PR fixes:
Special notes for your reviewer:
The "conformance tests using VFS" job seems to be limited by I/O, as it's not faster when given more memory and more CPU, and actually appears to be slower when we add the parallelization here. The overlay counterpart, however, finishes in less time than it did before.
Does this PR introduce a user-facing change?