Skip to content

[WIP][DO NOT MERGE] test vendoring for https://github.com/containers/container-libs/pull/734#6832

Open
giuseppe wants to merge 2 commits into
containers:mainfrom
giuseppe:test-storage-fix
Open

[WIP][DO NOT MERGE] test vendoring for https://github.com/containers/container-libs/pull/734#6832
giuseppe wants to merge 2 commits into
containers:mainfrom
giuseppe:test-storage-fix

Conversation

@giuseppe
Copy link
Copy Markdown
Member

@giuseppe giuseppe commented May 6, 2026

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 6, 2026
@giuseppe
Copy link
Copy Markdown
Member Author

giuseppe commented May 6, 2026

the failure seems related to the change, need to investigate it

giuseppe added 2 commits May 6, 2026 16:44
and bump container-libs/common too

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the test-storage-fix branch from 2221476 to 4636f37 Compare May 6, 2026 14:45
Comment thread tests/namespaces.bats
done
}

@test "idmapping-non-contiguous-maps" {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless I a missing something that test passes on main so this is not a regression test of the bug reported?!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using overlay as storage driver?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or at least I think I do not sure if the test overwrite anything, I just do sudo bats -f "idmapping-non-contiguous-maps" tests/namespaces.bats with a buildah build on main not of this branch

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set STORAGE_DRIVER=overlay, can you try the following command?

sudo STORAGE_DRIVER=overlay bats -f "idmapping-non-contiguous-maps" tests/namespaces.bats

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes that fails, sorry I was not aware that vfs is the test default locally.

   Error: building at STEP "RUN useradd -u 579841 -g 67283 -s /bin/bash -m crunbuild": ensuring mount targets for container "28c00debdd6d34ea47a9652df9342ea94aee72f7a786d936fe558c145d7a843c": copier: ensure: error checking item "dev/mqueue": mkdir /dev/mqueue: permission denied

I assume that is the expected error before your patch?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is the error I am seeing too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants