Bump github.com/openshift/imagebuilder from v1.2.10 to v1.2.11 #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump github.com/openshift/imagebuilder from v1.2.10 to v1.2.11 Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Reject the new ADD --keep-git-dir, COPY --parents, and ADD/COPY --link and ADD/COPY --exclude flags. The behavior they ask for isn't implemented (yet), and rejecting the flags outright is far preferable to quietly ignoring them. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
added
the
No New Tests
|
Ephemeral COPR build failed. @containers/packit-build please check. |
flouthoc
approved these changes
Jun 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
|
/unhold |
openshift-merge-bot
bot
merged commit dde8d7e
into
containers:main
35 of 36 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Bump github.com/openshift/imagebuilder from v1.2.10 to v1.2.11 and, for now, reject COPY or ADD instructions that use the new flags that it recognizes that we don't yet implement.
How to verify it
It shouldn't be rejecting anything that the current tests do. As we implement the new features, any tests that we added to ensure that they were rejected would have to be thrown away, so this PR currently doesn't add any.
Which issue(s) this PR fixes:
Fixes part of containers/podman#23046.
Special notes for your reviewer:
Does this PR introduce a user-facing change?