Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some NetBSD support #5559

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

coypoop
Copy link
Contributor

@coypoop coypoop commented Jun 2, 2024

I've been using podman on NetBSD, which uses some buildah code as a dependency.
I will note that buildah itself is not working (aside from building with the buildah target after these changes), but it would be nice not to have to patch the vendored buildah code in podman.

/kind other

Signed-off-by: Maya Rashish <maya@NetBSD.org>
If it's linux, darwin, and a BSD, it might be easier to write it this
way.

Intended to add support for NetBSD.

Signed-off-by: Maya Rashish <maya@NetBSD.org>
No CLOCK_UPTIME on netbsd, we have to use a sysctl.

Signed-off-by: Maya Rashish <maya@NetBSD.org>
@edsantiago edsantiago added the No New Tests Allow PR to proceed without adding regression tests label Jun 3, 2024
@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

You should modify the Makefile to build netbsd to make sure no regressions get added to Buildah.

 grep -i freebsd Makefile 
ifeq ($(shell uname -s),FreeBSD)
# FreeBSD needs CNI until netavark is supported
FREEBSD_CROSS_TARGETS := $(filter bin/buildah.freebsd.%,$(ALL_CROSS_TARGETS))
cross: $(LINUX_CROSS_TARGETS) $(DARWIN_CROSS_TARGETS) $(WINDOWS_CROSS_TARGETS) $(FREEBSD_CROSS_TARGETS)

@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2024

@dfr PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 11, 2024

@dfr
Copy link
Contributor

dfr commented Jun 11, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 11, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coypoop, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9989113 into containers:main Jun 11, 2024
32 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants