-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] Packit: enable c10s downstream sync #5514
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
Ephemeral COPR build failed. @containers/packit-build please check. |
@nalind @TomSweeneyRedHat PTAL . |
All kinds of red test unhappiness @lsm5 |
Yes, those are expected because of the On the flip side, if centos stream tests pass and epel tests fail, then it's safe to say the RHEL tests will pass after sometime. I will check with packit team if it's possible to |
This commit will enable downstream syncing to CentOS Stream 10. The centos maintainer will need to manually run `packit propose-downstream` and `centpkg build` until better centos integration is in place. This commit also builds both rhel9 and centos9 copr rpms so we can check for things like differences in golang compiler. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
This is failing on c9s because the golang update to restore the HashSign and HashVerify symbols hasn't landed in buildroot yet. The change itself should be good to go |
/lgtm |
e795e68
into
containers:main
/cherrypick release-1.36 |
@lsm5: new pull request created: #5561 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Do we have any expectations around when golang-1.22.3-2.el9 will be showing up there? |
@nalind i'm told whenever the next compose goes out. Hard to tell the exact date I guess. |
This commit will enable downstream syncing to CentOS Stream 10. The centos maintainer will need to manually run
packit propose-downstream
andcentpkg build
until better centos integration is in place.This commit also builds both rhel9 and centos9 copr rpms so we can check for things like differences in golang compiler.
What type of PR is this?
/kind other
What this PR does / why we need it:
enables downstream syncing to c10s
How to verify it
can't be verified pre-merge. After a release is cut, the centos maintainer will run
packit propose downstream -p buildah-centos
to trigger a centos merge request.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?