Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix test/tools ginkgo typo #5455

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Asutorufa
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

tests/tools/tools.go import wrong ginkgo package name

How to verify it

$ cd tests/tools
$ go mod tidy
go: finding module for package github.com/onsi/ginkgo/ginkgo/v2
go: github.com/containers/buildah/tests/tools imports
	github.com/onsi/ginkgo/ginkgo/v2: module github.com/onsi/ginkgo@latest found (v1.16.5), but does not contain package github.com/onsi/ginkgo/ginkgo/v2

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 3, 2024
Copy link

github-actions bot commented May 4, 2024

A friendly reminder that this PR had no activity for 30 days.

@nalind
Copy link
Member

nalind commented Aug 5, 2024

Ah, thanks for catching this! Any chance I can get you to rebase and use git commit --amend -s to add a Signed-off-by: to the log message for your commit? That should appease the DCO test in CI.

Signed-off-by: Asutorufa <16442314+Asutorufa@users.noreply.github.com>
@Asutorufa
Copy link
Contributor Author

@nalind Thanks for you review, please check again.

@nalind
Copy link
Member

nalind commented Aug 6, 2024

Tests passed, looks good. Thanks!

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Asutorufa, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a5c7f6c into containers:main Aug 6, 2024
37 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants