Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: add support for git sources #5438

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

danishprakash
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds support for git sources with the ADD directive

How to verify it

Which issue(s) this PR fixes:

Fixes #4974

Special notes for your reviewer:

Does this PR introduce a user-facing change?

adds support for git sources with the ADD directive

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@danishprakash danishprakash force-pushed the add-git-ref branch 3 times, most recently from da7f372 to 92ed66a Compare April 23, 2024 14:40
@danishprakash danishprakash marked this pull request as ready for review April 23, 2024 14:41
@TomSweeneyRedHat
Copy link
Member

Quick fly by review looks OK to me, but you have test issues and a rebase is needed.

@danishprakash
Copy link
Contributor Author

Quick fly by review looks OK to me, but you have test issues and a rebase is needed.

You meant packit issues? Because tests seems to be fine afaict

add.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

LGTM other then remove the MustCompile.

@flouthoc @nalind @giuseppe PTAL

add.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented May 21, 2024

LGTM
@flouthoc @giuseppe @nalind @mheon PTAL

@TomSweeneyRedHat
Copy link
Member

Changes LGTM

I did a rebase which was required, and now the DCO (signing) test is not passing. Did you forget to sign a recent commit @danishprakash ?

@danishprakash
Copy link
Contributor Author

I switched git emails recently, that was the issue, fixed now.

@rhatdan
Copy link
Member

rhatdan commented May 30, 2024

Needs a rebase.

add.go Outdated Show resolved Hide resolved
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
Signed-off-by: Danish Prakash <contact@danishpraka.sh>
@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2024

/approve
/lgtm
Thanks @danishprakash

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danishprakash, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 19e7088 into containers:main Sep 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ADD <git ref> in Containerfile
6 participants