Skip to content

Update c/storage after https://github.com/containers/storage/pull/1436 #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 3, 2022
Merged

Update c/storage after https://github.com/containers/storage/pull/1436 #4430

openshift-merge-robot merged 1 commit into from
Dec 3, 2022

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Nov 21, 2022

No description provided.

@mtrmac
Copy link
Contributor Author

mtrmac commented Nov 21, 2022

Now includes updates to avoid newly deprecated interfaces.

@mtrmac mtrmac mentioned this pull request Nov 21, 2022
Merged
@mtrmac mtrmac force-pushed the modified-test branch 2 times, most recently from e42f8ef to f5b67df Compare November 21, 2022 23:36
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2022
@mtrmac
Update c/storage after containers/storage#1436
a1698cd 
... and update to remove the now-deprecated Locker interface.

[NO NEW TESTS NEEDED]

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Contributor Author

mtrmac commented Dec 1, 2022 •
edited
Loading

The c/storage PR was merged, and requires Buildah updates from this PR to avoid now-deprecated interfaces.

So, leaving this PR open, and ready for merge at some point. Merging it before the eventual vendor dance, and running the new code base in the meantime, might also improve our confidence in the c/storage changes a bit.

@mtrmac mtrmac changed the title DO NOT MERGE: Testing https://github.com/containers/storage/pull/1436 Update c/storage after https://github.com/containers/storage/pull/1436 Dec 1, 2022
@mtrmac mtrmac marked this pull request as ready for review December 1, 2022 14:45
@mtrmac mtrmac mentioned this pull request Dec 1, 2022
Closed
@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2022

/approve
LGTM
@flouthoc PTAL

@openshift-ci openshift-ci bot added the approved label Dec 2, 2022
flouthoc
flouthoc approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nalind @containers/buildah-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, mtrmac, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit a27bd0b into containers:main Dec 3, 2022
@mtrmac mtrmac deleted the modified-test branch December 5, 2022 16:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees

@rhatdan rhatdan

Labels

approved lgtm locked - please file new issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtrmac @rhatdan @flouthoc @openshift-merge-robot