Skip to content

Add an option to ignore SIGINT and SIGQUIT - #732

Open
GalaxySnail wants to merge 2 commits into
containers:mainfrom
GalaxySnail:ignore-signal
Open

GalaxySnail wants to merge 2 commits into
containers:mainfrom
GalaxySnail:ignore-signal

Conversation

@GalaxySnail

@GalaxySnail GalaxySnail commented Mar 9, 2026 •

Copy link
Copy Markdown

see details: #369 (comment)

@valentindavid

Copy link
Copy Markdown

No please. We need to set the foreground process.

@GalaxySnail

Copy link
Copy Markdown
Author

No please. We need to set the foreground process.

As discussed in #369 (comment), bwrap and its child process have already been foreground processes by default, we shouldn't need to do anything further.

@valentindavid

Copy link
Copy Markdown

No please. We need to set the foreground process.

As discussed in #369 (comment), bwrap and its child process have already been foreground processes by default, we shouldn't need to do anything further.

Nope. You can see this #735 works.

@GalaxySnail

Copy link
Copy Markdown
Author

Nope. You can see this #735 works.

Unfortunately it doesn't. I've replied there.

Signed-off-by: GalaxySnail <me@glxys.nl>
Signed-off-by: GalaxySnail <me@glxys.nl>
@martinetd

Copy link
Copy Markdown

FWIW I can confirm this works for me for interactive workloads, and is much simpler than trying to forward signals the right place.

Code-wise looks good to me but I'm not a contributor so take with a grain of salt, sorry for the "+1" style comment.

I also tried #586 (rebasing around the conflict manually) and it works as well but I feel that simpler is better here. I didn't try the recent LLM-assisted PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants