Repository navigation
Add an option to ignore SIGINT and SIGQUIT - #732
GalaxySnail wants to merge 2 commits into
Conversation
a19b003 to
e5feeec
Compare
|
No please. We need to set the foreground process. |
As discussed in #369 (comment), bwrap and its child process have already been foreground processes by default, we shouldn't need to do anything further. |
Nope. You can see this #735 works. |
Unfortunately it doesn't. I've replied there. |
Signed-off-by: GalaxySnail <me@glxys.nl>
Signed-off-by: GalaxySnail <me@glxys.nl>
e5feeec to
f82de2d
Compare
|
FWIW I can confirm this works for me for interactive workloads, and is much simpler than trying to forward signals the right place. Code-wise looks good to me but I'm not a contributor so take with a grain of salt, sorry for the "+1" style comment. I also tried #586 (rebasing around the conflict manually) and it works as well but I feel that simpler is better here. I didn't try the recent LLM-assisted PR... |
see details: #369 (comment)