lints: More cleanup && lints: Check for invalid /etc/hostname and /etc/resolv.conf #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is always clearer. Prep for adding another argument to this function that's an effective bool. Signed-off-by: Colin Walters <walters@verbum.org>
Two goals: - The global static LINTS array is a conflict point - It's easier to lay out the lint info when it's next to each function; prep for extending the lint data more. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
changed the title
Detect problems from containers/buildah#4242 or similar. As part of this, add new infrastructure logic for lints that only operate on non-running roots (we expect these are mounted/written at runtime). Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lints: Use enum instead of bool
This is always clearer. Prep for adding another argument to this function
that's an effective bool.
Signed-off-by: Colin Walters walters@verbum.org
lints: Rework to use linkme
Two goals:
function; prep for extending the lint data more.
Signed-off-by: Colin Walters walters@verbum.org
lints: Check for invalid /etc/hostname and /etc/resolv.conf
Detect problems from containers/buildah#4242
or similar.
As part of this, add new infrastructure logic for lints that only operate on
non-running roots (we expect these are mounted/written at runtime).
Signed-off-by: Colin Walters walters@verbum.org