Update the logic for deleting pods/containers in podman_play #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
sshnaidm
reviewed
Mar 28, 2024
| changed = False | ||
| kube_file = self.module.params['kube_file'] | ||
|
|
||
| rc, out, err = self._command_run([self.executable, "kube", "play", "--down", kube_file]) |
There was a problem hiding this comment.
We can probably check in followups that nothing is removed, or something is remove,a nd set changed var accordingly.
$ podman kube play --down /home/sshnaidm/tmp/lite-pod.yaml
Pods stopped:
17b422aa4a3f3f4563d4faf029d2556fb07890b225b097a7dfae4a3395914c3a
Pods removed:
17b422aa4a3f3f4563d4faf029d2556fb07890b225b097a7dfae4a3395914c3a
Secrets removed:
Volumes removed:
$ podman kube play --down /home/sshnaidm/tmp/lite-pod.yaml
Pods stopped:
Pods removed:
Secrets removed:
Volumes removed:
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, this PR improves the logic for deleting pods/containers in podman_play, more specifically updates
remove_associated_podsand usespodman kube play --downinstead.