Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podman_image to specify CPU arch when pulling image #578

Merged
merged 6 commits into from
Apr 15, 2023

Conversation

nishipy
Copy link
Contributor

@nishipy nishipy commented Apr 12, 2023

Fixes #563.

nishipy and others added 5 commits April 5, 2023 02:57
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
@nishipy
Copy link
Contributor Author

nishipy commented Apr 12, 2023

After creating this PR, I added some commits and believe it works now. Please review it. Thanks!

Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one nit. Awesome work on tests!

plugins/modules/podman_image.py Outdated Show resolved Hide resolved
@nishipy
Copy link
Contributor Author

nishipy commented Apr 15, 2023

Oops, I have to add sign-off

Signed-off-by: nishipy <goodisonev4@gmail.com>
@nishipy nishipy changed the title Update to specify CPU arch when pulling image Update podman_image to specify CPU arch when pulling image Apr 15, 2023
@sshnaidm sshnaidm merged commit ab64d5f into containers:master Apr 15, 2023
@sshnaidm
Copy link
Member

Amazing, thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting the architecture of the image when pulling images
2 participants