Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podman_image to remove image with image id #434

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

nishipy
Copy link
Contributor

@nishipy nishipy commented Jun 7, 2022

Fixes #357.

Signed-off-by: nishipy <goodisonev4@gmail.com>
@sshnaidm
Copy link
Member

sshnaidm commented Jun 7, 2022

Thanks, can you please add a test here? https://github.com/containers/ansible-podman-collections/blob/master/tests/integration/targets/podman_image/tasks/main.yml
You can use podman_image_info module to discover an ID

Signed-off-by: nishipy <goodisonev4@gmail.com>
@nishipy
Copy link
Contributor Author

nishipy commented Jun 8, 2022

Thanks for your comment! I added some lines in tests/integration/targets/podman_image/tasks/main.yml.

@nishipy nishipy changed the title Update to remove image with image id. Update to remove image with image id Jun 8, 2022
@sshnaidm
Copy link
Member

sshnaidm commented Jun 8, 2022

Please sign your commit: git commit -s, it's must in all repos in this org.
You can do git commit -s --amend and git push --force just to add the signature.
All commits should be signed.

Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
@nishipy
Copy link
Contributor Author

nishipy commented Jun 8, 2022

Please sign your commit: git commit -s, it's must in all repos in this org. You can do git commit -s --amend and git push --force just to add the signature. All commits should be signed.

I added them to all commits so far.

@nishipy nishipy changed the title Update to remove image with image id Update podman_image to remove image with image id Jun 8, 2022
@sshnaidm sshnaidm merged commit acedce8 into containers:master Jun 8, 2022
@sshnaidm
Copy link
Member

sshnaidm commented Jun 8, 2022

Awesome! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[podman_image Feature Request] Allow removing image with image id
2 participants