Skip to content

chore: Update protobuf dependency to latest #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/shim-protos/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ required-features = ["async"]

[dependencies]
async-trait = { workspace = true, optional = true }
# protobuf 3.5 introduces a breaking change: https://github.com/containerd/rust-extensions/issues/295
# pinning to <3.5.0 until we can update the generated code
protobuf = ">= 3.0, <3.5.0"
protobuf = "3.7.2"
ttrpc = "0.8.3"

[build-dependencies]
ttrpc-codegen = "0.4.2"
# TODO - replace git sha with next version that incudes the changes from the sha below
# ttrpc-codegen = "0.5.0"
ttrpc-codegen = { git = "https://github.com/containerd/ttrpc-rust", rev = "4929e9079941e7ead82fae3911340f8cbe810e7e" }

[dev-dependencies]
ctrlc = { version = "3.0", features = ["termination"] }
Expand Down
2 changes: 1 addition & 1 deletion crates/shim-protos/examples/ttrpc-server-async.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ impl Task for FakeServer {
async fn main() {
simple_logger::SimpleLogger::new().init().unwrap();

let tservice = create_task(Arc::new(Box::new(FakeServer::new())));
let tservice = create_task(Arc::new(FakeServer::new()));

let mut server = Server::new()
.bind("unix:///tmp/shim-proto-ttrpc-001")
Expand Down
2 changes: 1 addition & 1 deletion crates/shim-protos/examples/ttrpc-server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl Task for FakeServer {
fn main() {
simple_logger::SimpleLogger::new().init().unwrap();

let tservice = create_task(Arc::new(Box::new(FakeServer::new())));
let tservice = create_task(Arc::new(FakeServer::new()));

let mut server = Server::new()
.bind("unix:///tmp/shim-proto-ttrpc-001")
Expand Down
6 changes: 3 additions & 3 deletions crates/shim-protos/tests/ttrpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fn create_ttrpc_context() -> (

#[test]
fn test_task_method_num() {
let task = create_task(Arc::new(Box::new(FakeServer::new())));
let task = create_task(Arc::new(FakeServer::new()));
assert_eq!(task.len(), 17);
}

Expand All @@ -96,7 +96,7 @@ fn test_create_task() {
request.set_timeout_nano(10000);
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));

let task = create_task(Arc::new(Box::new(FakeServer::new())));
let task = create_task(Arc::new(FakeServer::new()));
let create = task.get("/containerd.task.v2.Task/Create").unwrap();
create.handler(ctx, request).unwrap();

Expand Down Expand Up @@ -137,7 +137,7 @@ fn test_delete_task() {
request.set_timeout_nano(10000);
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));

let task = create_task(Arc::new(Box::new(FakeServer::new())));
let task = create_task(Arc::new(FakeServer::new()));
let delete = task.get("/containerd.task.v2.Task/Delete").unwrap();
delete.handler(ctx, request).unwrap();

Expand Down
2 changes: 1 addition & 1 deletion crates/shim/src/asynchronous/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ mod tests {
let barrier2 = barrier.clone();
let server_thread = tokio::spawn(async move {
let listener = UnixListener::bind(&path1).unwrap();
let service = create_events(Arc::new(Box::new(server)));
let service = create_events(Arc::new(server));
let mut server = Server::new()
.set_domain_unix()
.add_listener(listener.as_raw_fd())
Expand Down
2 changes: 1 addition & 1 deletion crates/shim/src/synchronous/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ mod tests {

#[cfg(windows)]
{
let service = client::create_events(Arc::new(Box::new(FakeServer {})));
let service = client::create_events(Arc::new(FakeServer {}));

Server::new()
.bind(server_address)
Expand Down
Loading