-
Notifications
You must be signed in to change notification settings - Fork 81
Minimum runc shim implementation #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8df2b57
to
b720b17
Compare
Hi, all! I'm from Huawei Cloud Company. My team has implemented a whole runc shim that can truly run a runc container and it works well with containerd and even kubernetes for mounths in production . Now that having noticed this "rust-extensions" project, we'd like to open our work and provide LTS as well. Actually, this commit is only a part just including some basic tasks(eg. create/start/exec/wait/kill/delete/shutdown...), the other tasks will be brought up if this commit can be accepted. Hope you can take our implementation into consinderations. You can build it and replace to where the containerd-shim-runc-v2 (go verison) is for your own, use |
This commit has many features as you see, no limited to this:
Honestly, this commit may still have defects or something like that:
There is still some work needed to be done, perhaps we can develop together! |
I'll fix the CI checks and continue to add changes lately, don't worry~ |
@AkihiroSuda I don't think it is duplicate 😄 I Checkout this patch and it provides more helpers like go-runc-shim, for instance,fifo scheme support and pure runC commandline. I would like to say it can work with #21 or #27 together. WDYT? Cc @mxpv |
4e93126
to
2794e1f
Compare
I just pushed again and it passed CI finally. |
2794e1f
to
53291f9
Compare
When handling container IO, we take a method that pass the stdio from request task to runc directly, which is quite different from pipeIO. Cause we think our solution has higher efficiency than CopyIO in shim layer. |
} | ||
|
||
impl Container for RuncContainer { | ||
#[cfg(not(feature = "async"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxpv async
feature defined in Cargo.toml
used here
53291f9
to
bf29361
Compare
Implement shim cli commands and some basic task APIs to run a runc container Co-authored-by: Feng Shaobao fshb1988@gmail.com Co-authored-by: Zhang Tianyang burning9699@gmail.com Co-authored-by: Yu Qitao yuqitao1024@qq.com Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
Signed-off-by: Zhang Tianyang <burning9699@gmail.com>
bf29361
to
117263d
Compare
update done. ping @mxpv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @mxpv |
Implement shim cli commands and some basic task APIs to run a runc container
Co-authored-by: Feng Shaobao fshb1988@gmail.com
Co-authored-by: Zhang Tianyang burning9699@gmail.com
Co-authored-by: Yu Qitao yuqitao1024@qq.com
Signed-off-by: Zhang Tianyang burning9699@gmail.com