Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fscache: simple fixup for busy mountpoint #83

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jun 29, 2022

When snapshotter exits (either normally or abnormally), it will not have a
chance to umount erofs mountpoint, so if snapshotter resumes running and mount
again (by a new request to create container), it will need to ignore the mount
error device or resource busy.

Signed-off-by: Yan Song yansong.ys@antfin.com

@imeoer imeoer changed the title [WIP] fscache: simple fixup for busy mountpoint fscache: simple fixup for busy mountpoint Jun 29, 2022
When snapshotter exits (either normally or abnormally), it will not have a
chance to umount erofs mountpoint, so if snapshotter resumes running and mount
again (by a new request to create container), it will need to ignore the mount
error `device or resource busy`.

Signed-off-by: Yan Song <yansong.ys@antfin.com>
@codecov-commenter
Copy link

Codecov Report

Merging #83 (dc3e940) into main (f780759) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   28.78%   28.78%           
=======================================
  Files          17       17           
  Lines        1501     1501           
=======================================
  Hits          432      432           
  Misses       1005     1005           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f780759...dc3e940. Read the comment docs.

@imeoer imeoer merged commit 6767372 into containerd:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants