-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/auth: remove CRI Alpha API #611
Conversation
bced0c2
to
98bd867
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 34.36% 34.31% -0.05%
==========================================
Files 65 65
Lines 6606 6598 -8
==========================================
- Hits 2270 2264 -6
+ Misses 4021 4020 -1
+ Partials 315 314 -1
|
CRI v1alpha2 is deprecated since containerd 1.7: https://github.com/containerd/containerd/blob/v1.7.0/RELEASES.md#deprecated-features Co-authored-by: apostasie <spam_blackhole@farcloser.world> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
98bd867
to
f46b631
Compare
@imeoer rebased, and I included some of the fixes from @apostasie (from #604) in this patch, adding them as co-author. My goal with these sets of PRs was to see if we could have a release with the new modules in place (removing the ones deprecated in containerd) before this module moves to v2, so that I can update the version used in BuildKit in preparation of dependencies starting to move to containerd v2 (these module moves in containerd are intended to help with that transition to make sure a common module is used between v1 and v2 codebases).
|
cc @changweige |
FWIW: I opened a draft PR to test current main branch to verify it all works ok in BuildKit in case doing a v0.13.15 from current main is an option; |
LGTM! |
v0.14.0 released, thanks! cc @thaJeztah @apostasie |
CRI v1alpha2 is deprecated since containerd 1.7:
https://github.com/containerd/containerd/blob/v1.7.0/RELEASES.md#deprecated-features