Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/auth: remove CRI Alpha API #611

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah force-pushed the remove_cri_alpha branch 3 times, most recently from bced0c2 to 98bd867 Compare August 1, 2024 08:00
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.31%. Comparing base (261dd69) to head (f46b631).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   34.36%   34.31%   -0.05%     
==========================================
  Files          65       65              
  Lines        6606     6598       -8     
==========================================
- Hits         2270     2264       -6     
+ Misses       4021     4020       -1     
+ Partials      315      314       -1     
Files Coverage Δ
pkg/auth/image_proxy.go 75.51% <100.00%> (+0.07%) ⬆️

CRI v1alpha2 is deprecated since containerd 1.7:
https://github.com/containerd/containerd/blob/v1.7.0/RELEASES.md#deprecated-features

Co-authored-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review August 1, 2024 08:19
@thaJeztah
Copy link
Member Author

@imeoer rebased, and I included some of the fixes from @apostasie (from #604) in this patch, adding them as co-author.

My goal with these sets of PRs was to see if we could have a release with the new modules in place (removing the ones deprecated in containerd) before this module moves to v2, so that I can update the version used in BuildKit in preparation of dependencies starting to move to containerd v2 (these module moves in containerd are intended to help with that transition to make sure a common module is used between v1 and v2 codebases).

⚠️ Given that this PR removes some functionality, perhaps it warrants a v0.14.0
❓ maybe tagging current main / #610 as v0.13.15 ?

@thaJeztah thaJeztah mentioned this pull request Aug 1, 2024
@imeoer
Copy link
Collaborator

imeoer commented Aug 1, 2024

cc @changweige

@thaJeztah
Copy link
Member Author

FWIW: I opened a draft PR to test current main branch to verify it all works ok in BuildKit in case doing a v0.13.15 from current main is an option;

@imeoer
Copy link
Collaborator

imeoer commented Aug 2, 2024

LGTM!

@imeoer imeoer merged commit 8e72f94 into containerd:main Aug 2, 2024
16 checks passed
@imeoer
Copy link
Collaborator

imeoer commented Aug 2, 2024

v0.14.0 released, thanks! cc @thaJeztah @apostasie

@thaJeztah thaJeztah deleted the remove_cri_alpha branch August 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants