Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot: fix error on proxy driver when switching different snapshotter #593

Merged
merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. snapshot: fix error on proxy driver when switching different snapshotter

    During image pull, the containerd client calls Prepare API with the label containerd.io/snapshot.ref.
    When an image is pulled by other snapshotter, containerd doesn't send the label "containerd.io/snapshot.ref" to
    nydus snapshotter to let snapshotter prepare ro layers.
    Consequently, the code logic in nydus snapshotter cannot find label "containerd.io/snapshot/nydus-proxy-mode"
    and the logic of guest pull (proxy) is skipped.
    This occurs while reading the label data of parent snapshots(ro layers) during the preparation of the active snapshot(rw layer).
    Thus, when the snapshotter driver is configured to proxy mode, nydus snapshotter is compelled to implement the proxy logic.
    
    Fixes: containerd#592
    
    Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
    ChengyuZhu6 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8b98d6a View commit details
    Browse the repository at this point in the history