Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: publish manifest for multiple tags #585

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

BbolroC
Copy link
Contributor

@BbolroC BbolroC commented Mar 18, 2024

The PR #584 overlooked a scenario involving more than two elements in steps.meta.outputs.tags. This commit addresses that by iterating over the tags and creating/pushing a manifest for them, respectively.

Fixes: #583

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@BbolroC BbolroC changed the title action: publish docker manifest only for latest action: publish manifest more than two tags Mar 18, 2024
@BbolroC BbolroC changed the title action: publish manifest more than two tags action: publish manifest for multiple tags Mar 18, 2024
@BbolroC
Copy link
Contributor Author

BbolroC commented Mar 18, 2024

The PR containerd#584 overlooked a scenario involving more than two elements
in `steps.meta.outputs.tags`. This commit addresses that by iterating
over the tags and creating/pushing a manifest for them, respectively.

Fixes: containerd#583

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit c7841c7 into containerd:main Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-arch support for a nydus-snapshotter image
2 participants