Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup file system package #285

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

changweige
Copy link
Member

@changweige changweige commented Dec 13, 2022

  1. Don't let file system object store configurations of daemon anymore. All daemon configurations should be fetched from snapshotter config manager and have nothing to do with the file system package.
  2. File system package just acts as a thin abstraction layer to do Mount and Umount for snapshotter no matter a daemon has to be started or not to serve file system service.

No major logic is changed in this PR.

@changweige changweige force-pushed the cleanup-fs-pkg branch 2 times, most recently from ca5ae41 to a7f9763 Compare December 14, 2022 06:57
Filesystem no longger keeps configurations of daemon.
It should just be  thin layer to abstract file system
operations especially for Mount and Umount.

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@changweige changweige marked this pull request as ready for review December 14, 2022 07:00
@codecov-commenter
Copy link

Codecov Report

Base: 33.88% // Head: 33.97% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (9b01f43) compared to base (3d0e02d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   33.88%   33.97%   +0.09%     
==========================================
  Files          30       30              
  Lines        3223     3223              
==========================================
+ Hits         1092     1095       +3     
+ Misses       2019     2016       -3     
  Partials      112      112              
Impacted Files Coverage Δ
pkg/blob/blob_manager.go 32.65% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@changweige changweige merged commit 84c7439 into containerd:main Dec 15, 2022
@changweige changweige deleted the cleanup-fs-pkg branch January 18, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants