print which directories are being deleted #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
reviewed
Sep 29, 2022
| @@ -822,6 +822,8 @@ func (o *snapshotter) cleanupSnapshotDirectory(ctx context.Context, dir string) | |||
| log.G(ctx).WithError(err).WithField("dir", dir).Error("failed to unmount") | |||
| } | |||
|
|
|||
| log.L.Infof("Delete snapshot directory %s", dir) | |||
|
|
|||
| if err := os.RemoveAll(dir); err != nil { | |||
There was a problem hiding this comment.
Move after here and say Deleted snapshot directory %s?
| @@ -400,6 +400,9 @@ func (m *Manager) CleanUpDaemonResources(d *daemon.Daemon) { | |||
| if d.IsMultipleDaemon() { | |||
| resource = append(resource, d.SocketDir) | |||
| } | |||
|
|
|||
| log.L.Infof("deleting resources %v", resource) | |||
|
|
|||
| for _, dir := range resource { | |||
There was a problem hiding this comment.
Move after here and say Deleted resources %v?
Otherwise, it skips checking nydusd's socket's existence. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
This is very helpful when debug and trace how nydus-snapshotter is releasing resources. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
print-deleting-dirs
branch
from
a475637
to
68bcd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very helpful when debug and trace how
nydus-snapshotter is releasing resources.
Signed-off-by: Changwei Ge gechangwei@bytedance.com