[Bugfix] Modify the logic of obtaining image ref when deleting snapshots #170
Conversation
Codecov ReportBase: 30.25% // Head: 30.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 30.25% 30.25%
=======================================
Files 20 20
Lines 1626 1626
=======================================
Hits 492 492
Misses 1069 1069
Partials 65 65 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| if err := o.fs.DelSnapshot(imageID); err != nil { | ||
| return errors.Wrap(err, "failed to delete snapshot in cache manager") | ||
| if _, ok := snap.Labels[label.TargetSnapshotRef]; ok { | ||
| if imageID, ok := snap.Labels[label.CRIImageRef]; ok { |
There was a problem hiding this comment.
Why need to check if a particular label existed for the deleted snapshot? What's the problem if we delete a snapshot which does not meet the labels combination?
There was a problem hiding this comment.
Does it work for OCI image layer?
There was a problem hiding this comment.
As discussed with @power-more , it does not affect the OCI layer.
In some cases, such as a user-defined label in the upper layer, the snapshot label is not empty, but does not contain "containerd.io/snapshot/cri.image-ref", the function should continue to execute normally instead of returning an error. Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
power-more
force-pushed
the
zhaoshang/remove-label
branch
from
b3313f4
to
3c88f4a
Compare
|
LGTM |
In some cases, such as a user-defined label in the upper layer, the snapshot label is not empty, but does not contain
"containerd.io/snapshot/cri.image-ref", the function should continue to execute normally instead of returning an error.
Signed-off-by: zhaoshang zhaoshangsjtu@linux.alibaba.com