converter: make backend package independent #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `pkg/converter/backend` to `pkg/backend`. The advantage of this change is that if a component imports the converter package, but it doesn't need backend support, the non-direct dependencies in `pkg/backend` don't have to be imported either. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 30.05% 29.26% -0.79%
==========================================
Files 20 20
Lines 1647 1647
==========================================
- Hits 495 482 -13
- Misses 1087 1100 +13
Partials 65 65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Can we rename backend to storage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
pkg/converter/backendtopkg/backend.The advantage of this change is that if a component imports the
converter package, but it doesn't need backend support, the non-direct
dependencies in
pkg/backenddon't have to be imported either.Signed-off-by: Yan Song imeoer@linux.alibaba.com