use xid to generate nydusd's internal ID #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original ID generation method spawns a string with lower case, upper case and undersocre, which is too complicated. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 29.17% 28.55% -0.63%
==========================================
Files 19 19
Lines 1611 1611
==========================================
- Hits 470 460 -10
- Misses 1079 1089 +10
Partials 62 62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original ID generation method spawns a string with
lower case, upper case and undersocre, which is too complicated.
Signed-off-by: Changwei Ge gechangwei@bytedance.com