Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a flag to control whether enable kubeconfig keychain #131

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

changweige
Copy link
Member

If node has no kubelet deployed, listener will report warning forver:

E0815 10:37:46.330502 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused
E0815 10:38:30.398522 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused
E0815 10:39:08.890713 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused

Signed-off-by: Changwei Ge gechangwei@bytedance.com

@codecov-commenter
Copy link

Codecov Report

Merging #131 (767918d) into main (e6cc1fa) will increase coverage by 0.68%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   28.49%   29.17%   +0.68%     
==========================================
  Files          19       19              
  Lines        1604     1611       +7     
==========================================
+ Hits          457      470      +13     
+ Misses       1085     1079       -6     
  Partials       62       62              
Impacted Files Coverage Δ
config/config.go 0.00% <ø> (ø)
pkg/auth/keychain.go 32.55% <ø> (ø)
pkg/auth/kubesecret.go 34.02% <20.00%> (+10.30%) ⬆️
cmd/containerd-nydus-grpc/pkg/command/flags.go 77.18% <85.71%> (+0.30%) ⬆️
pkg/filesystem/fs/blob_manager.go 44.44% <0.00%> (-11.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/auth/kubesecret.go Outdated Show resolved Hide resolved
If node has no kubelet deployed, listener will report warning forver:

E0815 10:37:46.330502 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused
E0815 10:38:30.398522 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused
E0815 10:39:08.890713 1446182 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.5/tools/cache/reflector.go:167: Failed to watch *v1.Secret: failed to list *v1.Secret: Get "https://127.0.0.1:27949/api/v1/secrets?fieldSelector=type%3Dkubernetes.io%2Fdockerconfigjson&limit=500&resourceVersion=0": dial tcp 127.0.0.1:27949: connect: connection refused

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@changweige changweige merged commit 34a0a36 into containerd:main Aug 16, 2022
@changweige changweige deleted the enable-kubeconfig-keychain branch August 24, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants