-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINTAINERS: Add Yan Song as a reviewer #108
Conversation
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 28.77% 27.57% -1.20%
==========================================
Files 17 17
Lines 1536 1494 -42
==========================================
- Hits 442 412 -30
+ Misses 1030 1024 -6
+ Partials 64 58 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment about the formatting of the file (otherwise lgtm 😅)
09a055d
to
2b79723
Compare
2b79723
to
0e005c4
Compare
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
0e005c4
to
159a3a4
Compare
Or we could add Yan Song as committer as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I personally feel OK about adding Yan Some as a committer based on his remarkable contribution. But I am not sure if it is normal to directly add a committer according to Containerd's governance. |
Seven days have passed. Let's merge this and welcome @imeoer to join the nydus-snapshotter maintainers team :) |
Yan Song @imeoer is a core developer and maintainer of Nydus container image service, especially on the
nydusd
runtime/filesystem and building nydus container image vianydus-image
,nydusify
and Harbor Accelleratioin Service sub-project. For nydus-snapshotter he had completed features like the setting up nydus snapshots using Erofs/Fscache fs driver, which directly works on top of Linux in-kernel filesystem as container rootfs with lazyload capability, an essential feature in the upcoming nydus release. In addition, he contributed to the feature that nydus-snapshotter can directly use stargz container image to provide container rootfs with many other neat fixups.He is eager to help community users with rich experience.
I'd like to invite him as a nydus-snapshotter reviewer if he would approve :)
Needs explicit LGTM from @imeoer and 1/3 of the nydus-snapshotter Committers: