Skip to content

[CI BUST FIX]: fix docker target (disable docker testing for SigProxyFalse) #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented May 8, 2025

See #4219 for details.

Note that it is not 100% clear to me if docker fixed a legitimate issue and our test is wrong, or if this is unintended on their part.

One way or the other, disabling the test for now for docker so that we uncork the CI.

(fix #4219 )

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie changed the title Disable docker testing for SigProxyFalse [CI]: disable docker testing for SigProxyFalse May 8, 2025
@apostasie apostasie changed the title [CI]: disable docker testing for SigProxyFalse [CI]: fix docker CI bustage (disable docker testing for SigProxyFalse) May 8, 2025
@apostasie
Copy link
Contributor Author

Rootful failure is #3556

@apostasie
Copy link
Contributor Author

Tagging @Shubhranshu153 so that we do not duplicate effort on this.

@apostasie apostasie changed the title [CI]: fix docker CI bustage (disable docker testing for SigProxyFalse) [CI BUST FIX]: fix docker target (disable docker testing for SigProxyFalse) May 8, 2025
@apostasie apostasie marked this pull request as ready for review May 8, 2025 21:40
@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone May 8, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 51b5cf6 into containerd:main May 8, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]: docker now fails (a lot) TestLogsWithStartContainer
2 participants