-
Notifications
You must be signed in to change notification settings - Fork 667
[CI]: rewrite logs tests #4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: rewrite logs tests #4209
Conversation
451d61a
to
55da1df
Compare
9f07391
to
ef8c1b5
Compare
df306c5
to
a3388e7
Compare
a3388e7
to
c03cdf3
Compare
I have been sitting on this for a bit, as I couldn't make logs to work perfectly locally (see tickets), but I think it is time to merge and bring all logs tests to the new testing framework. Worse case scenario, we flag them "flaky" and they go back to the retry bucket. Poking @AkihiroSuda @fahedouch |
c03cdf3
to
aab31dc
Compare
Rebased for good measure. |
Failures unrelated. |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
aab31dc
to
8bd7a7d
Compare
Rebased. |
Failure is #4243 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
thanks @apostasie Sorry for the delay, I was sick for the last two days. |
Commit 1 relaxes RunSigProxy refresh frequency.
Suspicion is that currently this is putting extra pressure on the runtime - especially for slow environments like EL.
Commit 2 rewrites all remaining logs tests with the new framework.
IMPORTANT NOTES:
-d
, as this is a significant source of flakyness - if this is not acceptable and we do believe that all these tests must be run with-d
, let me know and I will come up with something elseNote that while torturing tests, the following issues showed-up:
Because of these, logs tests may/will fail randomly.