Make CreateNetwork safer wrt concurrency #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
bug-proactive-net-lock
branch
from
9432c6c to
bd1eefa
Compare
|
Specifically, I have hopes that this might fix the spurious |
|
@AkihiroSuda CI is green. This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I am progressing through rewriting tests, the actual code issues are starting to show up more.
#3086 is definitely biting.
While we should consider rewriting CNIEnv on top of
Storeand ensure it is fully safe, this here will help a little bit in the interim.Previous version had a lock, but somehow did enumerate the conf folder outside of it.