[CANARY] Disable test retries #3189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO we cannot keep on hiding problems by "retrying tests" until it works.
This is a doomed approach.
I perfectly understand how painful it is to go and debug these flakyness / concurrency issues, and that it is much easier to ignore the problem - but we have to solve these - they are definitely indicative of deep quality issues and the only way to do so is to make it as obvious as possible instead of hiding it under the retry-carpet.
This is a canary PR that will very likely keep failing for some time - until we fix ALL these issues.
I will rebase it against main daily, and eventually we should get it green and stable.
Finally note that this canary is usually AHEAD of main - using commits from pending PRs fixing flakyness