Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Make script compatible to python 2.7 and python 3.6 #1575

Closed
wants to merge 3 commits into from
Closed

Make script compatible to python 2.7 and python 3.6 #1575

wants to merge 3 commits into from

Conversation

vteratipally
Copy link
Contributor

@vteratipally vteratipally commented Sep 14, 2020

Signed-off-by: Varsha Teratipally teratipally@google.com

@k8s-ci-robot
Copy link

Hi @vteratipally. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vteratipally vteratipally changed the title Making the script compatible to python 2.7 and python 3.5 Making the script compatible to python 2.7 and python 3.6 Sep 14, 2020
@vteratipally vteratipally changed the title Making the script compatible to python 2.7 and python 3.6 Make script compatible to python 2.7 and python 3.6 Sep 14, 2020
@vteratipally
Copy link
Contributor Author

/assign @bsdnet, @dims

cluster/gce/configure.sh Outdated Show resolved Hide resolved
@bsdnet
Copy link

bsdnet commented Sep 14, 2020

/assign @Random-Liu @dims

This blocks kubernetes/test-infra#19207
and similar to containerd/containerd#4559

@vteratipally
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

@vteratipally: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Random-Liu
Copy link
Member

/ok-to-test

@vteratipally
Copy link
Contributor Author

I have tested this by creating a gce instance with config and the containerd and docker services are running properly now.

@Random-Liu
Copy link
Member

/lgtm
/approve

This is a GCE specific change that unblocks the OSS Kubernetes testing.

@bsdnet
Copy link

bsdnet commented Sep 14, 2020

/lgtm

One nit: Can you merge two commits into one in this PR?

@k8s-ci-robot
Copy link

@bsdnet: changing LGTM is restricted to collaborators

In response to this:

/lgtm

One nit: Can you merge two commits into one in this PR?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vteratipally
Copy link
Contributor Author

/retest

@estesp
Copy link
Member

estesp commented Sep 14, 2020

The commits have no Signed-off-by: and therefore the DCO check is failing the CI run

@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants