fix: don't abort on first encountered error when resetting Windows console #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsole When resetting the Windows console modes, we must not abort on the first encountered error, otherwise we might leave the console in an unexpected state. This is easily reproducible by calling SetRaw while stdout is redirected: Reset will abort restoring console modes after failing to reset stdout, which leaves stderr in its raw state. Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com>
kzys
approved these changes
Mar 7, 2023
Member
dcantah
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resetting the Windows console modes, we must not abort on the first encountered error, otherwise we might leave the console in an unexpected state.
This is easily reproducible by calling SetRaw while stdout is redirected: Reset will abort restoring console modes after failing to reset stdout, which leaves stderr in its raw state.