Skip to content

Add missing import in freebsd nocgo stub #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Apr 9, 2021
Merged

Add missing import in freebsd nocgo stub #52

fuweid merged 1 commit into from
Apr 9, 2021

Conversation

@zhsj
Copy link
Contributor

@zhsj zhsj commented Apr 8, 2021 

$ GOOS=freebsd CGO_ENABLED=0 go build .
# github.com/containerd/console
./pty_freebsd_nocgo.go:30:17: undefined: os

@zhsj
Add missing import in freebsd nocgo stub
63603f4 
Signed-off-by: Shengjing Zhu <zhsj@debian.org>
thaJeztah
thaJeztah approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Apr 8, 2021 •
edited
Loading

looks like it was introduced in #50

Should we add a cross target in github actions to catch these?

@thaJeztah
Copy link
Member

thaJeztah commented Apr 8, 2021

@samuelkarp @crosbymichael ptal

samuelkarp
samuelkarp approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

fuweid
fuweid approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 2f1e3d2 into containerd:master Apr 9, 2021
@zhsj zhsj deleted the fix-import branch April 9, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@fuweid fuweid fuweid approved these changes

+1 more reviewer

@thaJeztah thaJeztah thaJeztah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhsj @thaJeztah @samuelkarp @fuweid