Skip to content

Add cgroup2 hugetlb failcnt metric #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

gavinkflam
Copy link
Contributor

@gavinkflam gavinkflam commented Jun 15, 2025

We are missing hugetlb failcnt metric for cgroup2.

According to kernel doc, this can be sourced from hugetlb.<hugepagesize>.events.

hugetlb..events
A read-only flat-keyed file which exists on non-root cgroups.

max
The number of allocation failure due to HugeTLB limit

@gavinkflam gavinkflam force-pushed the stats-hugetlb-failcnt branch 2 times, most recently from 4edfc51 to 0f02356 Compare June 15, 2025 00:45
Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
@gavinkflam gavinkflam force-pushed the stats-hugetlb-failcnt branch from 0f02356 to 14deda3 Compare June 15, 2025 00:47
@gavinkflam
Copy link
Contributor Author

@AkihiroSuda Noticed you recently reviewed a similar PR. Would you mind taking a look at this one as well when you have a chance?

@gavinkflam
Copy link
Contributor Author

Thank you, @AkihiroSuda. Could we merge this please?

@AkihiroSuda AkihiroSuda merged commit 071c31a into containerd:main Jul 14, 2025
8 checks passed
@gavinkflam gavinkflam deleted the stats-hugetlb-failcnt branch July 15, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants