Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/genproto to use isolated rpc submodule #550

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 8, 2023

What type of PR is this?

Dependency update

What this PR does / why we need it:

Updates genproto to use the isolated submodule. This reduces overall dependency count and avoids future issues with ambiguous imports. See googleapis/go-genproto#1015 for details.

Does this PR introduce an API-breaking change?:

none

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt
Copy link
Contributor Author

liggitt commented Aug 10, 2023

cc @saad-ali

Copy link
Member

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jdef
Copy link
Member

jdef commented Aug 11, 2023

Cc @bswartz

Copy link
Contributor

@bswartz bswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bswartz bswartz merged commit 80d5310 into container-storage-interface:master Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants