Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc build by cloning dependencies via Makefile #438

Merged
merged 1 commit into from
May 31, 2020
Merged

Fix grpc build by cloning dependencies via Makefile #438

merged 1 commit into from
May 31, 2020

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented May 30, 2020

@gnufied gnufied changed the title Fix grpc build by using makefile Fix grpc build by cloning dependencies via Makefile May 30, 2020
@xing-yang
Copy link
Contributor

LGTM

saad-ali
saad-ali approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to fix broken build

@saad-ali saad-ali merged commit f0dd1c2 into container-storage-interface:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@jdef jdef jdef approved these changes

@jieyu jieyu jieyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floating grpc dependencies and build failures
5 participants
@gnufied @xing-yang @jieyu @jdef @saad-ali