Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent edition of investments if budget is in the final phase #2223

Conversation

iagirre
Copy link

@iagirre iagirre commented Dec 27, 2017

Where

What

If the budget is in the final phase, prevent any changes in their investments except the milestones, which can be managed as always.

How

  • "Selected" link is conditional, so if the budget is finished it appears like text (to see if it is selected or not).
  • All the "Edit" links are removed if the budget is finished, only the milestones section is enabled.

Screenshots

"Selected" link

selected01

"Edit" links

selected02

Test

Feature spects to test that the "Selected" and "Edit" links are not appearing.

Deployment

Nothing.

Warnings

Nothing.

iagirre added 2 commits December 27, 2017 12:15
… not displayed/enabled.

"Selected" button appears as text instead of dissapearing completely.
Copy link
Contributor

@MariaCheca MariaCheca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MariaCheca MariaCheca merged commit c27e6ab into consuldemocracy:master Jan 9, 2018
@MariaCheca MariaCheca mentioned this pull request Jan 10, 2018
@iagirre iagirre deleted the iagirre-prevent-edition-if-budget-final-phase branch January 16, 2018 07:15
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
…ent-edition-if-budget-final-phase

Prevent edition of investments if budget is in the final phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent changes on investments after budget is on final phase
3 participants