Fix prompts dups - #9
Merged
Merged
Conversation
…nsure uniqueness and clarity. Introduced a shared root skill entrypoint bootstrap workflow fragment to standardize entrypoint handling in workflows. Updated tests to validate uniqueness of PDSL unit and menu names, ensuring no exact duplicates exist. Signed-off-by: ainetx <viator@via-net.org>
…ng and context management. Introduced shared context pack ownership and confirmation mechanisms for write-capable modes. Updated related specifications and requirements for clarity and consistency. Signed-off-by: ainetx <viator@via-net.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughRefactors common controller/workflow behaviors into shared PDSL/Markdown fragments (runtime activation, partial checkpoints, root bootstrap, shared context ownership, write-confirmation), updates requirements/workflows/agents to LOAD and CONTINUE those fragments, renames many generic UNIT identifiers to unique controller-specific names, and adds tests to prevent duplicate PDSL definitions. ChangesShared Contract Extraction and Unit Naming Standardization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
skills/studio/agents/cf-semantic-reviewer-code.md (2)
149-149:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winUpdate CONTINUE reference to match renamed unit.
Line 149 references
ContextBudgetFailSafein a CONTINUE statement, but this unit was renamed toCfSemanticReviewerCodeContextBudgetFailSafeat line 50.🔧 Proposed fix
- CONTINUE ContextBudgetFailSafe + CONTINUE CfSemanticReviewerCodeContextBudgetFailSafe🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/studio/agents/cf-semantic-reviewer-code.md` at line 149, Update the CONTINUE statement that references the old unit name: replace the reference to ContextBudgetFailSafe with the renamed unit CfSemanticReviewerCodeContextBudgetFailSafe so the CONTINUE points to the correct unit (search for the CONTINUE ContextBudgetFailSafe occurrence near the current line 149 and change it to CONTINUE CfSemanticReviewerCodeContextBudgetFailSafe).
101-101:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winUpdate reference to match renamed unit.
Line 101 references
ContextBudgetFailSafe, but this unit was renamed toCfSemanticReviewerCodeContextBudgetFailSafeat line 50. The reference must be updated to use the new name.🔧 Proposed fix
- - REQUIRE ContextBudgetFailSafe is active + - REQUIRE CfSemanticReviewerCodeContextBudgetFailSafe is active🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/studio/agents/cf-semantic-reviewer-code.md` at line 101, Update the outdated reference: replace the old unit name ContextBudgetFailSafe with the renamed CfSemanticReviewerCodeContextBudgetFailSafe in the REQUIRE line so it matches the declaration; locate the REQUIRE statement that currently mentions ContextBudgetFailSafe and change it to CfSemanticReviewerCodeContextBudgetFailSafe to ensure the unit name matches the renamed symbol.
🧹 Nitpick comments (1)
workflows/shared/root-skill-entrypoint-bootstrap.md (1)
26-26: ⚡ Quick winFix capitalization inconsistency.
"ALWAYS If" should use lowercase "if" for proper grammar: "ALWAYS if this workflow file is opened directly".
📝 Proposed fix
- - ALWAYS If this workflow file is opened directly, STOP workflow phases until + - ALWAYS if this workflow file is opened directly, STOP workflow phases until🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@workflows/shared/root-skill-entrypoint-bootstrap.md` at line 26, Update the capitalization in the markdown sentence that currently reads "ALWAYS If this workflow file is opened directly, STOP workflow phases until" by changing "If" to lowercase "if" so it reads "ALWAYS if this workflow file is opened directly, STOP workflow phases until"; locate the phrase in workflows/shared/root-skill-entrypoint-bootstrap.md and apply the single-word capitalization change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/studio/agents/shared/context-budget-partial-checkpoint.md`:
- Line 24: The PDSL step incorrectly uses the lower-case imperative "RUN emit
PARTIAL_CHECKPOINT_FINDINGS payload" which is inconsistent with the repo's
emission syntax; replace that token with the canonical PDSL emission form "EMIT
PARTIAL_CHECKPOINT_FINDINGS payload" (or, if there's a justified runtime need
for a RUN-based emission, document that rationale next to the step). Update the
step containing "RUN emit" so it uses the "EMIT" keyword and ensure the emitted
symbol "PARTIAL_CHECKPOINT_FINDINGS" and its "payload" remain unchanged.
In `@workflows/pdsl/new.md`:
- Around line 30-36: The flow is wiring SharedPdslWriteConfirmGate/Menu but
PDSL_WRITE_CONFIRM_INPUTS points to NewPromptInputs which is not defined in
scope; either define NewPromptInputs in this flow before the LOAD/CONTINUE
(e.g., add a SET NewPromptInputs = <value/source>) or change
PDSL_WRITE_CONFIRM_INPUTS to an existing variable provided by the parent (e.g.,
the variable exported by workflows/pdsl.md), and then re-run with
SharedPdslWriteConfirmGate, SharedPdslWriteConfirmMenu, PDSL_WRITE_CONFIRM_MODE,
PDSL_WRITE_CONFIRM_PRECONDITIONS and PDSL_WRITE_CONFIRM_AGENT unchanged so the
menu dispatch has a valid input binding.
In `@workflows/shared/shared-context-pack-ownership.md`:
- Around line 21-23: Edit the sentence containing the duplicated "ALWAYS" (the
phrase "the controller ALWAYS reuse or refresh SHARED_CONTEXT_PACK") to remove
redundancy and correct grammar—either remove the second "ALWAYS" and keep
imperative mood ("ALWAYS before any prompt-consuming dispatch, the controller
reuse or refresh SHARED_CONTEXT_PACK") or, better, change to
indicative/third-person ("the controller reuses or refreshes
SHARED_CONTEXT_PACK, load the agent prompt source, and synthesize the final
dispatch prompt...") so the wording is not duplicated and grammar matches the
sentence structure.
---
Outside diff comments:
In `@skills/studio/agents/cf-semantic-reviewer-code.md`:
- Line 149: Update the CONTINUE statement that references the old unit name:
replace the reference to ContextBudgetFailSafe with the renamed unit
CfSemanticReviewerCodeContextBudgetFailSafe so the CONTINUE points to the
correct unit (search for the CONTINUE ContextBudgetFailSafe occurrence near the
current line 149 and change it to CONTINUE
CfSemanticReviewerCodeContextBudgetFailSafe).
- Line 101: Update the outdated reference: replace the old unit name
ContextBudgetFailSafe with the renamed
CfSemanticReviewerCodeContextBudgetFailSafe in the REQUIRE line so it matches
the declaration; locate the REQUIRE statement that currently mentions
ContextBudgetFailSafe and change it to
CfSemanticReviewerCodeContextBudgetFailSafe to ensure the unit name matches the
renamed symbol.
---
Nitpick comments:
In `@workflows/shared/root-skill-entrypoint-bootstrap.md`:
- Line 26: Update the capitalization in the markdown sentence that currently
reads "ALWAYS If this workflow file is opened directly, STOP workflow phases
until" by changing "If" to lowercase "if" so it reads "ALWAYS if this workflow
file is opened directly, STOP workflow phases until"; locate the phrase in
workflows/shared/root-skill-entrypoint-bootstrap.md and apply the single-word
capitalization change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cedda752-5dec-4ba3-94ea-40ec96461b3f
📒 Files selected for processing (46)
.gitignorearchitecture/specs/PDSL.mdarchitecture/specs/sysprompts.mdrequirements/auto-config.mdrequirements/shared/runtime-activation-contract.mdrequirements/storytelling.mdskills/studio/agents/cf-code-bug-finder.mdskills/studio/agents/cf-deterministic-validator.mdskills/studio/agents/cf-generate-author.mdskills/studio/agents/cf-migrate-migrator.mdskills/studio/agents/cf-migrate-scanner.mdskills/studio/agents/cf-migrate-verifier.mdskills/studio/agents/cf-prompt-bug-finder.mdskills/studio/agents/cf-semantic-reviewer-artifact.mdskills/studio/agents/cf-semantic-reviewer-code.mdskills/studio/agents/cf-semantic-reviewer-consistency.mdskills/studio/agents/cf-semantic-reviewer-prompt.mdskills/studio/agents/shared/context-budget-partial-checkpoint.mdskills/studio/agents/storytelling-context-pack.mdskills/studio/agents/storytelling-export.mdskills/studio/agents/storytelling-gate.mdskills/studio/agents/storytelling-preflight.mdskills/studio/agents/storytelling-wrap.mdskills/studio/migrate-from-cypilot.mdskills/studio/protocol.mdskills/studio/sub-agent-dispatch.mdtests/test_pdsl_keywords.pytests/test_workflow_parsing.pyworkflows/analyze.mdworkflows/auto-config.mdworkflows/brainstorm.mdworkflows/explain.mdworkflows/explore.mdworkflows/generate.mdworkflows/help.mdworkflows/map.mdworkflows/pdsl.mdworkflows/pdsl/new.mdworkflows/pdsl/transform.mdworkflows/plan.mdworkflows/shared/pdsl-write-confirm-gate.mdworkflows/shared/pdsl-write-confirm-menu.mdworkflows/shared/root-skill-entrypoint-bootstrap.mdworkflows/shared/shared-context-pack-ownership.mdworkflows/studio.mdworkflows/workspace.md
…ious workflows. Updated context budget fail-safe references for clarity and consistency. Enhanced prompt input settings in new workflow mode and improved shared context pack ownership rules. Signed-off-by: ainetx <viator@via-net.org>
This was referenced Jun 2, 2026
ainetx
added a commit
that referenced
this pull request
Jun 30, 2026
…itions - Update cf-coding, cf-write-docs, cf-write-skills table rows to identify them as umbrella entrypoints listing their specialized sub-routes - Add cf-planning and cf-git-commit to the base skills table - Add note below the table about invoking sub-routes directly - Update USAGE-GUIDE section 6 intro to mention specialized sub-routes - Fix duplicate entries in "Best chat form" list; add cf-planning, cf-git-commit, and sub-route examples - Add "When the intent is already clear" sub-route hints under the coding, write-docs, and write-skills sections - Update practical habit #9 to mention specialized sub-routes Signed-off-by: ainetx <viator@via-net.org> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: cli=1.5.9 Studio-Workflows: cf-documenting-planning,cf-documenting-gen,cf-git-commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Refactor
Tests
Chores