Expose QR code generation functions #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 94.97% 94.99% +0.02%
==========================================
Files 5 6 +1
Lines 1393 1399 +6
==========================================
+ Hits 1323 1329 +6
Misses 70 70
☔ View full report in Codecov by Sentry. |
|
Hi! I see that for now there's duplicate code for get_qr_draw_canvas/draw_canvas, draw_png/qr_png, and draw_base64/qr_base64 Is this intentional? |
|
Oops, good catch, I forgot to remove the module from the earlier iteration of the PR, should be fixed now. 👍 |
|
Noice! I will do some tests later in the day :) |
constantoine
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.
No breaking changes, just re-arrange a little bit.