This repository was archived by the owner on Dec 16, 2021. It is now read-only.
Fix OAuth2 when custom arg_separator.output is defined #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth2 auth fails when a custom arg_separator.output is defined. Change http_build_query calls to force '&' arg separator.
Contributor
|
I'm wondering how this problem came up for you. In what case do are you defining a custom arg separator? |
Contributor
Author
|
Yes I work on an older codebase that has a custom arg_separator defined as This change should be safe for everyone (the default is |
Contributor
|
Great, thanks for explaining. We'll get this merged in for our next bugfix release. In the meantime, if you build from the composer version dev-development, you can get this fix. |
WoogieNoogie
added a commit
that referenced
this pull request
Dec 3, 2014
Fix OAuth2 when custom arg_separator.output is defined
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth2 auth fails when a custom arg_separator.output is defined. Change http_build_query calls to force '&' arg separator.