Upstream gvt restore patches: delete old deps and parallel downloads#547
Upstream gvt restore patches: delete old deps and parallel downloads#547FiloSottile wants to merge 2 commits intoconstabulary:masterfrom
Conversation
acd5c0c to
fabec39
Compare
There was a problem hiding this comment.
I cannot see where this is being set
|
Look, this is going to be an awkward conversation, but I don't want to take any patches for gb vendor restore. It was a mistake to accept that feature in the first place because it confuses the previous story that gb handles dependencies through vendoring into If you don't want to, or cannot vendor your dependency's source then I offer proposal #536 as an alternative. Thanks for your understanding. |
fabec39 to
e56b63d
Compare
|
I fully expected that reply. I'm equally unhappy about gvt restore. However, these are patches that I had accepted a long time ago in gvt, and I'm really trying to keep the core of gvt in sync with gb-vendor (for my own sanity). I believe these are pretty technical changes, nothing behavioral, so I gave upstreaming a try. I'd still be happier if this was accepted, after which I'd stop taking patches on gvt restore, too. But I'll understand if you close it, and I'll just keep the commits around and apply them to gb master if I need it when syncing. |
gvt had a command called rebuild, which looked exactly like restore (because I'm an idiot and didn't remember removing restore when doing the first port).
I renamed it restore, and this PR upstreams the two main changes that were applied to gvt rebuild: