fileutils: add support for copying symlinks to Copypath#534
fileutils: add support for copying symlinks to Copypath#534FiloSottile wants to merge 1 commit intoconstabulary:masterfrom
Conversation
This was removed instead of being special cased in constabulary#185, because gb has no direct need for it (see constabulary#184). However it's useful for other users of the library. For example gvt needs to retain test fixtures intact (as vendor/ packages are testable) and needs to support symlink-based packages (since the go build tool does). Fixes FiloSottile/gvt#12
|
@FiloSottile Thanks for adding this. I haven't been clear about the direction of this package at all, but the intention is to move it out to another package, probably github.com/pkg/fileutils, soon. Instead of carrying this feature inside gb where i'll probably drop it later and break you again, why don't I make the move of fileutils now, and then that package can evolve on it's own ? How does that sound ? |
|
Sure, sounds great! I am vendoring fileutils like a normal package in gvt anyway, so I can switch easily. |
|
Just a FYI, I'm working on the replacement for this package in github.com/pkg/fileutils. It isn't quite ready for prime time yet, but shouldn't take much longer. |
|
👍 As soon as you switch to that on gb, let me know and I'll port gvt |
|
Should I port this to github.com/pkg/fileutils? |
|
Probably, but wait a bit, i'm behind on finishing that package. On Mon, Jan 18, 2016 at 2:25 PM, Filippo Valsorda notifications@github.com
|
2 participants
This was removed instead of being special cased in #185, because gb has no
direct need for it (see #184). However it's useful for other users of the
library. For example gvt needs to retain test fixtures intact (as vendor/
packages are testable) and needs to support symlink-based packages (since
the go build tool does).
Fixes FiloSottile/gvt#12