Allow short options. Needed to pass along -vvv #76
Conversation
--verbose=3 is not allowed by its InputDefinition. --verbose does not accept a value (i.e. is VALUE_NONE). It must be passed as short option. So we enable convertOptions() to pass along short options via a magic value `-short`. Magic values of true and false are already supported so hopefully this doesnt smell too bad. This enables a fix for drush-ops/drush#5909
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
============================================
+ Coverage 77.85% 77.91% +0.05%
- Complexity 174 175 +1
============================================
Files 20 20
Lines 438 498 +60
============================================
+ Hits 341 388 +47
- Misses 97 110 +13 ☔ View full report in Codecov by Sentry. |
|
Test failure looks unrelated. |
There was a problem hiding this comment.
Sorry, I missed this before. I like the functionality that this adds, but I don't like overloading the option value to enable it. Instead, there should be an accessor for the ArgumentProcessor class that takes option names that should remain short. Since the libraries in this org are primarily intended for use with Symfony Console, it would be fine if ArgumentProcessor defaulted to treating -vv and -vvv as short options.
--verbose=3 is not allowed by its InputDefinition. --verbose does not accept a value (i.e. is VALUE_NONE). It must be passed as short option.
So we enable convertOptions() to pass along short options via a magic value
-short. Magic values of true and false are already supported so hopefully this doesnt smell too bad.This enables a fix for drush-ops/drush#5948