Stops ProcessBase::removeNonJsonJunk returning NULL when valid JSON i…

[edwinknl]

…s passed in

Overview

This pull request fixes issue #34

Q	A
Bug fix?	yes
New feature?	no
Has tests?	no
BC breaks?	no
Deprecations?	no

Summary

prevent passing strings into preg_replace that would cause the backtrack limit to be exceeded.

Description

See issue #34

[greg-1-anderson]

The php manual says:

Note:
It is usually not possible to match more than pcre.backtrack_limit characters in ungreedy mode.

The default mode is greedy, so I'm not sure why we'd have this limitation. Perhaps it has something to do with matching characters at the end of the string.

I'm not fond of the amount of work needed here just to get the regex to work. Perhaps a simpler solution that just used strrpos and a substring would also work?

[legolasbo]

The goal of the regexes is to remove any characters before the first { and any characters after the last }. So I recon we could definitely use strpos + substring for this. Great idea!

[greg-1-anderson]

Lost track of this PR. Looks exactly right. Thanks for the improvement.