test Task ReplaceInFile for multiple strings in file #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,14 +39,19 @@ $this->taskReplaceInFile('config.yml') | |||
| ->regex('~^service:~') | |||
| ->to('services:') | |||
| ->run(); | |||
|
|
|||
| $this->taskReplaceInFile('box/robo.txt') | |||
There was a problem hiding this comment.
please move this example to dockblock of the class.
this file is generated from it
pscheit
force-pushed
the
test-replace-multiple-in-file
branch
from
de02255
to
16b3a75
Compare
|
Okay, moved the example to the php-file. Unfortunately I cannot re-generate the docs (all md files are emptied) |
burzum
pushed a commit
to burzum/Robo
that referenced
this pull request
Mar 15, 2015
|
@pscheit is there still any kind of issue with this? What exactly do you mean by
Is this broken for everyone now or just for you? I referenced the wrong PR in my commit by the way. :( |
|
According to @DavertMik it's OK to merge this, doing it now. |
burzum
added a commit
that referenced
this pull request
Mar 15, 2015
Test Task ReplaceInFile for multiple strings in file
|
you are right. Whats the best way to fix? seperate PR? Or should I commit into this branch? I found the "bug" with the docs generation, my bad |
pscheit
added a commit
to pscheit/Robo
that referenced
this pull request
Mar 16, 2015
… regenerated docs
DavertMik
added a commit
that referenced
this pull request
Mar 23, 2015
fix PR #128 document replaceInFile with better example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the current implementation allows to supply an array of arguments for to and from, so that IO access to files can be minimized. I think this is a good feature, but I noticed that there is no test for that.
So I created a little test and a sentence in the documentation for this behaviour.
Best regards Philipp